Skip to content

Conversation

@jaudiger
Copy link
Contributor

@jaudiger jaudiger self-assigned this Jan 10, 2026
@jaudiger jaudiger marked this pull request as draft January 10, 2026 12:10
@jaudiger jaudiger force-pushed the update-rust-nightly branch from 32f2311 to 2545a7c Compare January 10, 2026 12:15
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
@jaudiger jaudiger force-pushed the update-rust-nightly branch from 2545a7c to 1a3a6e4 Compare January 10, 2026 12:15
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
@jaudiger
Copy link
Contributor Author

jaudiger commented Jan 10, 2026

Summary:

Before: https://github.com/brioche-dev/brioche-runtime-utils/actions/runs/20875827001
After: https://github.com/brioche-dev/brioche-runtime-utils/actions/runs/20878209652

  • aarch64-linux: No size changes between builds - all 7 binaries are identical
  • x86_64-linux: 3 binaries increased in size (+40 KB total, +0.59%):
    • brioche-packed-plain-exec: +24.0 KB (+12.36%)
    • brioche-packed-exec: +8.0 KB (+9.75%)
    • brioche-packed-userland-exec: +8.0 KB (+9.75%)

aarch64-linux

Binary Before After Diff Change
brioche-cc 452.1 KB 452.1 KB 0 B 0.00%
brioche-ld 1.6 MB 1.6 MB 0 B 0.00%
brioche-packed-exec 129.5 KB 129.5 KB 0 B 0.00%
brioche-packed-plain-exec 193.6 KB 193.6 KB 0 B 0.00%
brioche-packed-userland-exec 129.5 KB 129.5 KB 0 B 0.00%
brioche-packer 2.3 MB 2.3 MB 0 B 0.00%
brioche-strip 708.2 KB 708.2 KB 0 B 0.00%
-------------------------------- -------------- -------------- -------------- ----------
TOTAL 5.5 MB 5.5 MB 0 B 0.00%

x86_64-linux

Binary Before After Diff Change
brioche-cc 444.6 KB 444.6 KB 0 B 0.00%
brioche-ld 2.1 MB 2.1 MB 0 B 0.00%
brioche-packer 3.0 MB 3.0 MB 0 B 0.00%
brioche-strip 820.6 KB 820.6 KB 0 B 0.00%
brioche-packed-exec 82.0 KB 90.0 KB +8.0 KB +9.75%
brioche-packed-userland-exec 82.0 KB 90.0 KB +8.0 KB +9.75%
brioche-packed-plain-exec 194.1 KB 218.1 KB +24.0 KB +12.36%
-------------------------------- -------------- -------------- -------------- ----------
TOTAL 6.6 MB 6.7 MB +40.0 KB +0.59%

@jaudiger jaudiger requested a review from kylewlacy January 10, 2026 12:39
@jaudiger
Copy link
Contributor Author

jaudiger commented Jan 10, 2026

I'm fine if we don't merge it @kylewlacy, since the binary size increases a little bit. Just let me know. It was to test the new stabilised option on nightly.

Edit: Well, when this feature will be stabilised, we'll update the Rust toolchain at some point. So, if the binary size is increased, we have to accept it.
I think we can merge it, and let's see what will happen until the next time we want to update brioche-runtime-utils in brioche-packages.

Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's not great that the binary size increased, but it was a small change, and realistically that's just something we're going to need to deal with to stay on top of new versions. Thanks for taking the time to compare all the different binary sizes!

@kylewlacy kylewlacy merged commit 705f0f3 into main Jan 11, 2026
10 checks passed
@kylewlacy kylewlacy deleted the update-rust-nightly branch January 11, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants